]> git.infradead.org Git - nvme.git/commit
mips: Call lose_fpu(0) before initializing fcr31 in mips_set_personality_nan
authorXi Ruoyao <xry111@xry111.site>
Fri, 26 Jan 2024 21:05:57 +0000 (05:05 +0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Sat, 27 Jan 2024 10:08:04 +0000 (11:08 +0100)
commit59be5c35850171e307ca5d3d703ee9ff4096b948
tree50496d53f2491b14cd19366b5c863bd0eb9a8de7
parent822df315cc7c85c3c10afcc6408b254a6fa0f166
mips: Call lose_fpu(0) before initializing fcr31 in mips_set_personality_nan

If we still own the FPU after initializing fcr31, when we are preempted
the dirty value in the FPU will be read out and stored into fcr31,
clobbering our setting.  This can cause an improper floating-point
environment after execve().  For example:

    zsh% cat measure.c
    #include <fenv.h>
    int main() { return fetestexcept(FE_INEXACT); }
    zsh% cc measure.c -o measure -lm
    zsh% echo $((1.0/3)) # raising FE_INEXACT
    0.33333333333333331
    zsh% while ./measure; do ; done
    (stopped in seconds)

Call lose_fpu(0) before setting fcr31 to prevent this.

Closes: https://lore.kernel.org/linux-mips/7a6aa1bbdbbe2e63ae96ff163fab0349f58f1b9e.camel@xry111.site/
Fixes: 9b26616c8d9d ("MIPS: Respect the ISA level in FCSR handling")
Cc: stable@vger.kernel.org
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kernel/elf.c